
What is a prayer? When people say they pray what exactly do they do?
I haven't done a research on this and what I write here is more an introspection and a reflection than anything else. As I understand, most people try to connect with their preferred Deity when they pray. They use this as an occasion to thank the Almighty for blessings received, seek support for resolution of problems and ask for specific desires to be fulfilled.
When we pray, we remember our Lord and acknowledge His supremacy. Some people pray by chanting His names or singing songs in praise of Him. Over time various elaborate processes have been created for conduct during prayer. The simplest prayer is one wherein the eyes are closed, the hands are held together and the mind is focused on the Lord. Of course, there are people who pray with their eyes wide open and lips sealed. One can pray at any location or occasion. Any format is acceptable to Him.
Lord Krishna, in the Bhagvad Gita, says that four types of people pray - the distressed, the seeker of boons, the seeker of knowledge and the wise. While all of these people are on the right path and are dear to Him, it is the wise person who prays without any desires who is the dearest to the Lord.

So, what should one pray for? Asking for material things is pointless because it is short lived. Also, the human mind is such that it never gets satisfied. So, one tends to keep asking for more and more. Moreover, like children, we sometimes ask / crave for things which are not good for us. Our minds are not so evolved as to ask for the rights things and the things that are in our interest.
If one believes that there is an Almighty who is our creator, who is fair & just, who knows everything and who cares & loves all his children, do we need to ask for anything? Does He not know what is good for us and give it to us without our asking? Does He not care for our spiritual and emotional growth and plans our lives accordingly?

Yet, there is something that is beyond even His control. This is our mind and our actions. If at all we should seek anything, it should be a pure mind which is grateful for His grace & mercies. We should also seek His grace to ensure that we never stray from the path of the righteous and always do actions which are right. For without His grace, we can get bewildered and confused and do things which we may regret or repent later.
Most of us pray. Some do this as a matter of routine every day while some pray occasionally. If we truly believe in Him, we should be praying every moment of our lives. Irrespective of what happens to us, we should remember Him. We should especially pray when we good things happens to us for that is the time when we naturally tend to get carried away and forget Him. When we tune our minds in this manner, we can say our mind is one with Him.
Our bodies will die one day but when our hearts are filled with His thoughts and prayers, we merge with the Supreme Lord. So, pray every day and every moment.
"A prayer is not a 'spare wheel' that you pull out when you are in trouble; It is a 'steering wheel' that directs you in the right path throughout your life" -
Anonymous